Skip to content

Setup optional CI jobs using pyright strict mode#954

Merged
Dr-Irv merged 3 commits intopandas-dev:mainfrom
JanEricNitschke:strict-ci
Jun 29, 2024
Merged

Setup optional CI jobs using pyright strict mode#954
Dr-Irv merged 3 commits intopandas-dev:mainfrom
JanEricNitschke:strict-ci

Conversation

@JanEricNitschke
Copy link
Contributor

@JanEricNitschke JanEricNitschke commented Jun 29, 2024

Setup a optional CI job that uses full pyright strict mode by taking its settings from pyrightconfig-strict.json.

Addresses the other points made here: #952

@JanEricNitschke JanEricNitschke mentioned this pull request Jun 29, 2024
Open
@JanEricNitschke
Copy link
Contributor Author

JanEricNitschke commented Jun 29, 2024

Did a test run here: https://github.com/JanEricNitschke/pandas-stubs/actions/runs/9726191446/job/26844350295

Dr-Irv
Dr-Irv approved these changes Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JanEricNitschke

It looks like there is a LOT of work to do to make the stubs work in strict mode.

@Dr-Irv Dr-Irv merged commit 9d5348e into pandas-dev:main Jun 29, 2024
@JanEricNitschke
Copy link
Contributor Author

JanEricNitschke commented Jun 29, 2024

Yeah, it is mostly missing type hints or type parameters. Would it make sense to enable the pyright_strict test also in PRs, currently i made it like the others where it only runs on commits to main and not on PR creation like the other optionals.

Might make sense to also have it run here to see the number of errors getting lower on changes?

@JanEricNitschke JanEricNitschke deleted the strict-ci branch June 30, 2024 08:01
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jun 30, 2024

Yeah, it is mostly missing type hints or type parameters. Would it make sense to enable the pyright_strict test also in PRs, currently i made it like the others where it only runs on commits to main and not on PR creation like the other optionals.

Might make sense to also have it run here to see the number of errors getting lower on changes?

I'm hesitant to do that, because then every PR will show a failure, which can be confusing to contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanEricNitschke @Dr-Irv